module: runtime deprecate `module.register()` by GeoffreyBooth · Pull Request #62401 · nodejs/node

GeoffreyBooth · 2026-03-23T03:13:06Z

Building on #62395, this runtime-deprecates module.register().

I’m not sure when we want to land and release this; I think the options are basically either:

When module.registerHooks() goes stable, hopefully sometime before 26 goes LTS; module: doc-deprecate module.register() #62395 (comment)
In 26.0.0; the doc-deprecation is backported to the 25.x line, and the runtime deprecation is 26+; module: doc-deprecate module.register() #62395 (comment)

I’m opening this now in case the team wants to do the second option. cc @nodejs/loaders @nodejs/userland-migrations

nodejs-github-bot · 2026-03-23T03:13:13Z

Review requested:

@nodejs/loaders
@nodejs/userland-migrations

codecov · 2026-03-23T05:10:35Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (f8ee196) to head (4d26994).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #62401   +/-   ##
=======================================
  Coverage   89.71%   89.71%           
=======================================
  Files         695      695           
  Lines      214108   214120   +12     
  Branches    40995    40995           
=======================================
+ Hits       192083   192108   +25     
+ Misses      14075    14064   -11     
+ Partials     7950     7948    -2

Files with missing lines	Coverage Δ
lib/internal/modules/esm/loader.js	`98.78% <100.00%> (+0.01%)`	⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AugustinMauroy

In general that seem good.

lib/internal/modules/esm/loader.js

doc/api/deprecations.md

mcollina

lgtm

I think we should aim for 26.x, so we can actually drop in 27

lib/internal/modules/esm/loader.js

mcollina

lgtm

gurgunday

lgtm

PR-URL: nodejs#62401

github-actions · 2026-03-31T20:02:44Z

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - module: runtime-deprecate module.register() (DEP0205)
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/23816881980

nodejs-github-bot · 2026-03-31T20:26:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72366/

nodejs-github-bot · 2026-03-31T21:50:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72371/

nodejs-github-bot · 2026-03-31T22:27:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72372/

nodejs-github-bot · 2026-03-31T23:40:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72374/

nodejs-github-bot · 2026-04-01T01:04:15Z

Commit Queue failed

- Loading data for nodejs/node/pull/62401 ✔ Done loading data for nodejs/node/pull/62401 ----------------------------------- PR info ------------------------------------ Title module: runtime deprecate `module.register()` (#62401) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch GeoffreyBooth:runtime-deprecate-module-register -> nodejs:main Labels semver-major, esm, author ready, loaders Commits 1 - module: runtime-deprecate module.register() (DEP0205) Committers 1 - Geoffrey Booth <webadmin@geoffreybooth.com> PR-URL: https://github.com/nodejs/node/pull/62401 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62401 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 23 Mar 2026 03:13:06 GMT ✔ Approvals: 5 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/62401#pullrequestreview-4037256459 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/62401#pullrequestreview-3993639689 ✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/62401#pullrequestreview-4026691029 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/62401#pullrequestreview-4033444263 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/62401#pullrequestreview-4040152054 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-03-31T23:40:03Z: https://ci.nodejs.org/job/node-test-pull-request/72374/ - Querying data for job/node-test-pull-request/72374/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 62401 From https://github.com/nodejs/node * branch refs/pull/62401/merge -> FETCH_HEAD ✔ Fetched commits as cd391b5f1195..a8414d2e6cf6 -------------------------------------------------------------------------------- [main 5e77224da6] module: runtime-deprecate module.register() (DEP0205) Author: Geoffrey Booth <webadmin@geoffreybooth.com> Date: Sun Mar 29 09:55:51 2026 -0700 5 files changed, 90 insertions(+), 2 deletions(-) create mode 100644 test/es-module/test-esm-register-deprecation.mjs ✔ Patches applied -------------------------------------------------------------------------------- ⚠ Found PR-URL: https://github.com/nodejs/node/pull/62401, skipping.. --------------------------------- New Message ---------------------------------- module: runtime-deprecate module.register() (DEP0205)

Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

[main 66c6a93796] module: runtime-deprecate module.register() (DEP0205)
Author: Geoffrey Booth <webadmin@geoffreybooth.com>
Date: Sun Mar 29 09:55:51 2026 -0700
5 files changed, 90 insertions(+), 2 deletions(-)
create mode 100644 test/es-module/test-esm-register-deprecation.mjs
✖ 66c6a9379687c16ba9eb0cabf09b731176457858
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✖ 0:0 Commit must have a PR-URL. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
⚠ 0:50 Title should be <= 50 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/23826752669

PR-URL: nodejs#62401

nodejs-github-bot · 2026-04-01T02:17:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72379/

aduh95 · 2026-04-01T13:37:30Z

Landed in 0dfdec9

GeoffreyBooth requested review from joyeecheung and legendecas March 23, 2026 03:13

GeoffreyBooth added the loaders Issues and PRs related to ES module loaders label Mar 23, 2026

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Mar 23, 2026

GeoffreyBooth force-pushed the runtime-deprecate-module-register branch from c5ce15e to 77638cb Compare March 23, 2026 03:18

GeoffreyBooth force-pushed the runtime-deprecate-module-register branch from 77638cb to 1a08254 Compare March 23, 2026 03:51

AugustinMauroy reviewed Mar 23, 2026

View reviewed changes

lib/internal/modules/esm/loader.js Show resolved Hide resolved

doc/api/deprecations.md Show resolved Hide resolved

mcollina approved these changes Mar 23, 2026

View reviewed changes

aduh95 reviewed Mar 23, 2026

View reviewed changes

lib/internal/modules/esm/loader.js Show resolved Hide resolved

himself65 approved these changes Mar 23, 2026

View reviewed changes

GeoffreyBooth mentioned this pull request Mar 23, 2026

Node.js Technical Steering Committee (TSC) Meeting 2026-03-25 nodejs/TSC#1840

Closed

GeoffreyBooth added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Mar 23, 2026

jsumners-nr approved these changes Mar 24, 2026

View reviewed changes

openjs-meetings-bot bot mentioned this pull request Mar 26, 2026

Node.js Technical Steering Committee (TSC) Meeting 2026-04-01 nodejs/TSC#1845

Open

mcollina approved these changes Mar 29, 2026

View reviewed changes

gurgunday approved these changes Mar 29, 2026

View reviewed changes

GeoffreyBooth force-pushed the runtime-deprecate-module-register branch from 1a08254 to 2124d8a Compare March 29, 2026 16:47

GeoffreyBooth added a commit to GeoffreyBooth/node that referenced this pull request Mar 29, 2026

module: runtime-deprecate module.register() (DEP0205)

a0e36fb

PR-URL: nodejs#62401

GeoffreyBooth force-pushed the runtime-deprecate-module-register branch from 2124d8a to a0e36fb Compare March 29, 2026 16:56

GeoffreyBooth added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2026

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 29, 2026

This comment was marked as outdated.

Sign in to view

github-actions bot added the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Mar 31, 2026

joyeecheung approved these changes Mar 31, 2026

View reviewed changes

GeoffreyBooth added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 31, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 1, 2026

module: runtime-deprecate module.register()

4d26994

PR-URL: nodejs#62401

GeoffreyBooth force-pushed the runtime-deprecate-module-register branch from a8414d2 to 4d26994 Compare April 1, 2026 02:11

GeoffreyBooth removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 1, 2026

JakobJingleheimer approved these changes Apr 1, 2026

View reviewed changes

GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Apr 1, 2026

aduh95 removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 1, 2026

aduh95 mentioned this pull request Apr 1, 2026

fix(git-node): fix handling of existing trailers nodejs/node-core-utils#1056

Open

aduh95 merged commit 0dfdec9 into nodejs:main Apr 1, 2026
66 checks passed

GeoffreyBooth deleted the runtime-deprecate-module-register branch April 1, 2026 14:17

Uh oh!

Conversation

GeoffreyBooth commented Mar 23, 2026

Uh oh!

nodejs-github-bot commented Mar 23, 2026

Uh oh!

codecov bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

AugustinMauroy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

github-actions bot commented Mar 31, 2026

Uh oh!

nodejs-github-bot commented Mar 31, 2026

Uh oh!

nodejs-github-bot commented Mar 31, 2026

Uh oh!

nodejs-github-bot commented Mar 31, 2026

Uh oh!

nodejs-github-bot commented Mar 31, 2026

Uh oh!

nodejs-github-bot commented Apr 1, 2026

Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Uh oh!

nodejs-github-bot commented Apr 1, 2026

Uh oh!

Uh oh!

aduh95 commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

codecov bot commented Mar 23, 2026 •

edited

Loading

Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>